Certain types of food are often responsible for tooth discolouration. Beverages such as coffee, tea, red wine, certain soft drinks and coloured spices (e.g., curry, turmeric) can leave spots and stains on teeth.
Smoking
Substances like nicotine and tar form a film on the teeth, causing them to turn yellow.
Oral hygiene and plaque
Discolouration is often the result of build-up from poor oral hygiene. Furthermore, brushing one's teeth right after having an acidic meal can damage white enamel, allowing the yellow dentine layer underneath to shine through.